Changeset 5e6e9e6369150833509caab051a5ba44d30b89b5

Timestamp:

05/03/10 15:17:10 (3 years ago)

Author:

Jason Dixon <jdixon@omniti.com>

git-committer:

Jason Dixon <jdixon@omniti.com> 1272899830 +0000

git-parent:

[c8051cbc1da99542d24ed957f0fac1e7abb71c9f]

git-author:

Jason Dixon <jdixon@omniti.com> 1272899830 +0000

Message:

only create our kstat object once, update() each time. fixes memory leakage.

git-svn-id: https://labs.omniti.com/resmon/branches/resmon2@347 8c0face9-b7db-6ec6-c4b3-d5f7145c7d55

Files:

• lib/Core/Memstat.pm (modified) (2 diffs)

lib/Core/Memstat.pm

@@ -7 +7 @@
-
-use Resmon::ExtComm qw(run_command cache_command);
+
+my $osname = $^O;
+my $usekstat = 0;
+my $kstat;
+if ($osname eq 'solaris') {
+    eval "use Sun::Solaris::Kstat";
+    unless ($@) {
+        $usekstat = 1;
+        $kstat = Sun::Solaris::Kstat->new();
+    }
+}
-
-=pod
@@ -90 +101 @@
-    my $config = $self->{'config'};
-    my $vmstat_path = $config->{'vmstat_path'} || 'vmstat';
-    my $osname = $^O;
-
-    if ($osname eq 'solaris') {
-        my $usekstat = 0;
-        my $pagesize = run_command('pagesize');
-        my $kstat;
-        eval "use Sun::Solaris::Kstat";
-        unless ($@) {
-            $usekstat = 1;
-            $kstat = Sun::Solaris::Kstat->new();
-        }
-        if ($usekstat && $pagesize) {
-            my %metrics;
+            $kstat->update();
-            my $syspages = $kstat->{'unix'}->{0}->{'system_pages'};
-