Ticket #284 (closed defect: fixed)

Opened 5 years ago

Last modified 5 years ago

address clang noted logic errors

Reported by: jesus Assigned to: jesus
Priority: major Milestone:
Component: noit-core Severity: serious
Keywords: Cc:

Description (Last modified by jesus)

Output from Piotr Sikora's clang run:

Logic error	Dereference of null pointer	noit_conf.c	1218	8	View Report
Logic error	Dereference of null pointer	noit_conf.c	1126	11	View Report
Logic error	Dereference of null pointer	noit_conf.c	1125	10	View Report
Logic error	Dereference of null pointer	noit_conf.c	417	9	View Report
Logic error	Dereference of null pointer	noit_conf_checks.c	633	11	View Report
Logic error	Dereference of null pointer	noit_conf_checks.c	632	10	View Report
Logic error	Dereference of null pointer	noit_filters.c	398	3	View Report
Logic error	Dereference of null pointer	noit_http.c	662	8	View Report
Logic error	Dereference of null pointer	noitedit /emacs.c	232	5	View Report
Logic error	Dereference of null pointer	noitedit /readline.c	1744	3	View Report
Logic error	Dereference of null pointer	noitedit /readline.c	1687	11	View Report
Logic error	Dereference of null pointer	noitedit /readline.c	306	5	View Report
Logic error	Dereference of null pointer	utils /noit_skiplist.c	294	15	View Report
Logic error	Dereference of null pointer	utils /noit_skiplist.c	189	9	View Report
Logic error	Dereference of null pointer	utils /noit_skiplist.c	206	6	View Report
Logic error	Dereference of null pointer	utils /noit_skiplist.c	169	6	View Report
Logic error	Dereference of null pointer	stratcon_datastore.c	1390	9	View Report
Logic error	Dereference of null pointer	stratcon_datastore.c	1389	8	View Report
Logic error	Dereference of null pointer	stratcon_datastore.c	1388	7	View Report
Logic error	Dereference of null pointer	modules /external_proc.c	122	3	View Report
Logic error	Dereference of null pointer	modules /collectd.c	516	8	View Report

Change History

05/25/10 15:00:13 changed by jesus

(In [1300]) refs #284

05/25/10 15:01:09 changed by jesus

(In [1301]) refs #284

05/25/10 17:13:00 changed by jesus

  • status changed from new to assigned.
  • description changed.

Fixed the following:

Logic error	Pass-by-value argument in function call is undefined	modules /collectd.c	747	8	View Report
Logic error	Result of operation is garbage or undefined	noit_http.c	81	1	View Report
Logic error	Assigned value is garbage or undefined	modules /external_proc.c	91	1	View Report

05/25/10 17:17:33 changed by jesus

(In [1302]) makes clang happier, refs #284

05/27/10 17:24:59 changed by jesus

(In [1312]) refs #284

05/27/10 17:26:14 changed by jesus

(In [1313]) refs #284

05/27/10 17:32:42 changed by jesus

(In [1314]) refs #284

05/27/10 17:34:04 changed by jesus

(In [1315]) given noit_skiplist_find_compare, this is equivalent, refs #284

05/27/10 17:35:01 changed by jesus

(In [1316]) refs #284

05/27/10 17:38:09 changed by jesus

(In [1317]) refs #284

05/27/10 17:40:50 changed by jesus

(In [1318]) refs #284

05/27/10 17:45:01 changed by jesus

(In [1320]) can skip a whole lot more, refs #284

05/27/10 17:53:40 changed by jesus

(In [1322]) this is backwards... I can't simluate a meta to crash it though, refs #284

05/27/10 18:01:40 changed by jesus

(In [1323]) Safety is good, refs #284

05/27/10 19:23:20 changed by jesus

  • status changed from assigned to closed.
  • resolution set to fixed.