On May 22, 2009, at 8:20 AM, Theo Schlossnagle wrote:

>
> On May 22, 2009, at 1:43 AM, Dan Di Spaltro wrote:
>
>> Okay, so I tried to run the ping module locally.  Here is what I got.
>> Notice in the config I set the interval to be 5000 and the count to  
>> be
>> 10, but I don't think the xml parameters are getting picked up in the
>> ping module.

Indeed.  Noted below.

>> Obviously this should work, so I was rooting around in the code and
>> found this line of code, now is this incorrectly interpreting the  
>> ping
>> because the roundtrip is 0ms?
>> if(data->turnaround[i] != 0) {
>>  points++;
>> ...
>
> I'll check into that.  Seems suspect.

I can't repeat the issue you are seeing.  I'm not sure we could  
reasonably have a 0ms ttl (detected in noit).  However, I've adjusted  
the code to account for this case.  #132

Give it a whirl and see if it fixes your problem.

>> Trying to keep the everything as simple as possible, here is the  
>> config:
>>
>> <checks max_initial_stutter="30000" >
>>   <check module="ping_icmp" interval="5000" count="10"
>> period="15000" target="127.0.0.1"
>> uuid="1b6e28ba-2fa1-11d2-853f-b9a761bde3fb" timeout="14000" />
>> </checks>
>
> There is a problem.  The interval is set to 5000ms (5s).  You are  
> requesting 10 pings... This means, every 5 seconds it will send out  
> a new ICMP packet until it has sent 10.  However, you have a check  
> timeout of 14s and a period of 15s.  If you really do want 10 pings,  
> and want it to happen in 14s, I would suggest setting the interval  
> down to 1000ms.  That will give you enough time to get all of them  
> out and back in again.


So... the check itself has "first class" attributeds like period and  
target and timeout.  The "config" options are not part of that.

<check module="ping_icmp" period="15000" target="127.0.0.1">
<config>
   <interval>5000</interval>
   <count>10</count>
</config>
</check>

Note that you can inherit this across all ping checks as follows:

<ping>
  <config>
   <interval>5000</interval>
   <count>10</count>
  </config>

  <check module="ping_icmp" period="15000" target="127.0.0.1"/>
  <check .........
</ping>

--
Theo Schlossnagle
http://omniti.com/is/theo-schlossnagle
p: +1.443.325.1357 x201   f: +1.410.872.4911