[Reconnoiter-devel] Lua Fixes

Theo Schlossnagle jesus at omniti.com
Wed Sep 23 14:03:00 EDT 2009


On Sep 23, 2009, at 1:19 PM, Dan Di Spaltro wrote:

> Team,
>
> I made a couple "fixes" but they need some Theo feedback.
>
> * The timeout event log's the results yet there is no
> status,available, and state set.  I added three lines to that

+1

> * I added a bit more to the http parser to match on worse user input.
> And to also match on port.

Not sure about the port == '' stuff what about nil? or is that  
impossible there?

> * I changed the status to err or "unknown error" from str since that
> seems to be the desired effect.

+1

> * I made the consume callback get called no matter the body as long as
> the request is okay at this point.

+1

> * I made it display the error in the status field as the actual error
> text not the path + line_no, by going up the stack twice
>          err = lua_tostring(ci->coro_state, base - 2);

Not sure this is safe, but I think it is.


--
Theo Schlossnagle
http://omniti.com/is/theo-schlossnagle
p: +1.443.325.1357 x201   f: +1.410.872.4911







More information about the Reconnoiter-devel mailing list