Changeset e153d2640c610ffb28bb50ab34eaaefdfff65cc0

Timestamp:

07/28/11 22:56:38 (2 years ago)

Author:

Theo Schlossnagle <jesus@omniti.com>

git-committer:

Theo Schlossnagle <jesus@omniti.com> 1311893798 -0400

git-parent:

[9e093855ceddcd07647592f55ed557655b1cc24d]

git-author:

Theo Schlossnagle <jesus@omniti.com> 1311893798 -0400

Message:

Looks like the dev_t is 4 bytes and the ino_t is 8 leaving
4 bytes of unaligned trash in the jlog_file_id. We were
correctly memsetting the enclosing structure on insertion
into the hash table, but not memsetting the key for lookups
causing a failure to fetch and a subsequent failure to
insert (duplicate). Boom. Nasty.

Files:

• src/jlog/jlog_io.c (modified) (1 diff)

src/jlog/jlog_io.c

@@ -82 +82 @@
-  if (stat(path, &sb) == 0) {
-    if (!S_ISREG(sb.st_mode)) goto out;
+    memset(&id, 0, sizeof(id));
-    id.st_dev = sb.st_dev;
-    id.st_ino = sb.st_ino;