Changeset 82dc7d35bbaadf8d6f995fa74cd2135e6764188d

Timestamp:

10/19/11 01:27:04 (2 years ago)

Author:

Theo Schlossnagle <jesus@omniti.com>

git-committer:

Theo Schlossnagle <jesus@omniti.com> 1318987624 -0400

git-parent:

[cd621c2ce13e17f28a2aa89767ff1a14fe787306]

git-author:

Theo Schlossnagle <jesus@omniti.com> 1318987624 -0400

Message:

These are all memory leak fixes.
They are low priority leaks as they only happen at boot and
only consititue a one-time loss of 200 bytes or so on my box.
Cleanliness is cleanliness.

Files:

• src/modules/lua.c (modified) (4 diffs)
• src/noit_check_log.c (modified) (1 diff)
• src/noit_conf.c (modified) (2 diffs)
• src/noit_module.c (modified) (1 diff)

src/modules/lua.c

@@ -575 +575 @@
-  } \
-} while(0)
-
+, expr
-  int base = lua_gettop(L); \
-  assert(base == 1); \
@@ -582 +582 @@
-    rv = lua_tointeger(L, -1); \
-    lua_pop(L, 1); \
+    expr \
-    return rv; \
-  } \
@@ -596 +597 @@
-  noit_lua_setup_module(L, mod);
-  noit_lua_hash_to_table(L, options);
+  noit_hash_destroy(options, free, free);
+  free(options);
-  lua_pcall(L, 2, 1, 0);
-
-
+
+
+
-  return -1;
-}
@@ -609 +614 @@
-  lua_pcall(L, 1, 1, 0);
-
-
+, 
-  return -1;
-}

src/noit_check_log.c

@@ -392 +392 @@
-  }
-  free(bundle.metrics);
+  free(bundle.status);
-  return rv;
-}

src/noit_conf.c

@@ -307 +307 @@
-      strlcat(infile, path, PATH_MAX);
-    }
+    xmlFree(path);
-    config_include_nodes[i].doc = xmlParseFile(infile);
-    if(config_include_nodes[i].doc) {
@@ -460 +461 @@
-    snprintf(xpath_expr, sizeof(xpath_expr), "//*[@id=\"%s\"]", inheritid);
-    noit_conf_get_into_hash(NULL, xpath_expr, table);
+    xmlFree(inheritid);
-  }
-  /* 3. */

src/noit_module.c

@@ -509 +509 @@
-      continue;
-    }
-    config = noit_conf_get_hash(sections[i], "config");
-    if(module->config) {
-      int rv;
+      config = noit_conf_get_hash(sections[i], "config");
-      rv = module->config(module, config);
-      if(rv == 0) {