Changeset 5fd1894ad04542945430bed21cc582a937f8edcb for src

Timestamp:

04/22/12 16:46:08 (1 year ago)

Author:

Theo Schlossnagle <jesus@omniti.com>

git-committer:

Theo Schlossnagle <jesus@omniti.com> 1335113168 -0400

git-parent:

[66cf6d4b55d526fdb6724e700480033f198045fa]

git-author:

Theo Schlossnagle <jesus@omniti.com> 1335113168 -0400

Message:

a variety of memory leaks in console commands.

Files:

• src/noit_conf_checks.c (modified) (5 diffs)
• src/noit_console.c (modified) (1 diff)
• src/noit_console_complete.c (modified) (3 diffs)

src/noit_conf_checks.c

@@ -118 +118 @@
-nc_attr_show(noit_console_closure_t ncct, const char *name, xmlNodePtr cnode,
-             xmlNodePtr anode, const char *value) {
-onst c
-""
-""
+
+strdup("")
+strdup("")
-  nc_printf(ncct, " %s: %s", name, value ? value : "[undef]");
-  if(value && cpath && apath) {
@@ -134 +134 @@
-  }
-  nc_write(ncct, "\n", 1);
+  if(cpath) free(cpath);
+  if(apath) free(apath);
-}
-static void 
@@ -447 +449 @@
-    }
-    nc_printf(ncct, "==== %s ====\n", uuid_conf);
+    free(uuid_conf);
-
-#define MYATTR(a,n,b) _noit_conf_get_string(node, &(n), "@" #a, &(b))
@@ -456 +459 @@
-  INHERIT(a, anode, value); \
-  nc_attr_show(ncct, #a, node, anode, value); \
+  if(value != NULL) free(value); \
-} while(0)
-
@@ -464 +468 @@
-      nc_printf(ncct, " name: %s [from module]\n", module ? module : "[undef]");
-    nc_attr_show(ncct, "module", node, mnode, module);
+    if(module) free(module);
-    SHOW_ATTR(target);
-    SHOW_ATTR(resolve_rtype);

src/noit_console.c

@@ -299 +299 @@
-  else if(i<0) nc_printf(ncct, "Error at offset: %d\n", 0-i);
-  else noit_console_state_do(ncct, cnt, cmds);
+  while(cnt>0) free(cmds[--cnt]);
-}
-

src/noit_console_complete.c

@@ -97 +97 @@
-  noit_console_closure_t ncct;
-  const LineInfo *li;
-
+, *rv = NULL
-  int len, cnt = 32;
-
@@ -107 +107 @@
-
-  cmds = alloca(32 * sizeof(*cmds));
+  cmds[0] = NULL;
-  (void) noit_tokenize(curstr, cmds, &cnt);
-
@@ -112 +113 @@
-
-  if(!strlen(text)) {
-""
-
-== 32) return NULL;
-return
+strdup("")
+
+!= 32)
+  rv =
-                                   ncct->state_stack->state,
-                                   cnt, cmds, state);
+  if(cmds[0]) while(cnt > 0) free(cmds[--cnt]);
+  return rv;
-}
-static int